Hi David, I have an issue on Vega 10 where sudo xinit fails with [ 5801.227] Failed to allocate front buffer memory [ 5801.227] (EE) AMDGPU(0): amdgpu_setup_kernel_mem failed [ 5801.227] (EE) Fatal server error: [ 5801.227] (EE) AddScreen/ScreenInit failed for driver 0 [ 5801.227] (EE) [ 5801.227] (EE) Also in MESA code si_create_context->si_common_context_init->pipe_buffer_create returns NULL. Ellsmire works fine, on Vega 10 reverting this patch makes it work. I am during my test system upgrade right now with some more issues after this one, so I can spend time on debugging this once my system is in good shape, unless you have an answer to this problem right away. Thanks, Andrey On 02/09/2018 03:58 AM, Michel Dänzer wrote: > On 2018-02-09 07:01 AM, Chunming Zhou wrote: >> On 2018å¹´02æ??08æ?¥ 17:13, Chunming Zhou wrote: >>> On 2018å¹´02æ??08æ?¥ 17:01, Michel Dänzer wrote: >>>> this change completely broke radeonsi due to memory management errors >>>> (see valgrind output for glxgears below), so I had to revert it. >>> ok, I will look into what happens. Sorry for broken. >> The patch lost a "goto out" in free_va when applying patch from hybrid >> to opensource. >> The attached fixes that, I tested successfully in my local side. >>  please review or test, if no problem, I will submit it again. > Please add: > > v2: Add missing "goto out" > Tested-by: Michel Dänzer <michel.daenzer at amd.com> > > to the commit log before pushing. > >