Am 09.02.2018 um 18:28 schrieb Harry Wentland: > Signed-off-by: Harry Wentland <harry.wentland at amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > index 7d2805729c20..0a0f2eb67c01 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > @@ -406,7 +406,8 @@ int amdgpu_vmid_grab(struct amdgpu_vm *vm, struct amdgpu_ring *ring, > struct amdgpu_device *adev = ring->adev; > unsigned vmhub = ring->funcs->vmhub; > struct amdgpu_vmid_mgr *id_mgr = &adev->vm_manager.id_mgr[vmhub]; > - struct amdgpu_vmid *id, *idle; > + struct amdgpu_vmid *id = 0; > + struct amdgpu_vmid *idle = 0; Please use NULL not zero for initialization and reverse xmas tree order e.g. longest line first. Apart from that looks good to me, Christian. > int r = 0; > > mutex_lock(&id_mgr->lock);
