On 2018-02-08 10:15 AM, Chunming Zhou wrote:
> On 2018å¹´02æ??08æ?¥ 17:09, Michel Dänzer wrote:
>> On 2018-02-08 09:32 AM, Chunming Zhou wrote:
>>> it will be used to check if the driver needs swiotlb
>>>
>>> Change-Id: Idbe47af8f12032d4803bb3d47273e807f19169c3
>>> Signed-off-by: Chunming Zhou <david1.zhou at amd.com>
>>> Reviewed-by: Monk Liu <monk.liu at amd.com>
>>> ---
>>> Â include/drm/drm_cache.h | 13 +++++++++++++
>>> Â 1 file changed, 13 insertions(+)
>>>
>>> diff --git a/include/drm/drm_cache.h b/include/drm/drm_cache.h
>>> index beab0f0d0cfb..442c9ba63d03 100644
>>> --- a/include/drm/drm_cache.h
>>> +++ b/include/drm/drm_cache.h
>>> @@ -39,6 +39,19 @@ void drm_clflush_pages(struct page *pages[],
>>> unsigned long num_pages);
>>> Â void drm_clflush_sg(struct sg_table *st);
>>> Â void drm_clflush_virt_range(void *addr, unsigned long length);
>>> Â +static inline u64 drm_get_max_iomem(void)
>>> +{
>>> +Â Â Â struct resource *tmp;
>>> +Â Â Â u64 max_iomem = 0;
>>> +
>>> +Â Â Â for (tmp = iomem_resource.child; tmp; tmp = tmp->sibling) {
>>> +       max_iomem = max(max_iomem, tmp->end);
>>> +Â Â Â }
>>> +
>>> +Â Â Â return max_iomem;
>>> +}
>> I don't think this needs to be an inline function, does it?
> If no inline, will report building warning that this function is defined
> but not used in some files including drm_cache.h
What I mean is that it can be a normal function in drivers/gpu/drm/*.c
with EXPORT_SYMBOL.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
