On Wed, Feb 7, 2018 at 11:10 AM, Matthias Kaehlcke <mka at chromium.org> wrote:
> The double parentheses are not needed. Removing them fixes the following
> warning when building with clang:
>
> drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c:419:29:
> error: equality comparison with extraneous parentheses
> [-Werror,-Wparentheses-equality]
> if ((data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2)) {
>
> Signed-off-by: Matthias Kaehlcke <mka at chromium.org>
Reviewed-by: Guenter Roeck <groeck at chromium.org>
> ---
> drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c
> index 79e5c05571bc..f5b3de29b632 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c
> @@ -416,7 +416,7 @@ static int tonga_populate_cac_tables(struct pp_hwmgr *hwmgr,
> convert_to_vid(vddc_lookup_table->entries[index].us_cac_high);
> }
>
> - if ((data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2)) {
> + if (data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2) {
> /* We are populating vddgfx CAC data to BapmVddgfx table in split mode */
> for (count = 0; count < vddgfx_level_count; count++) {
> index = phm_get_voltage_index(vddgfx_lookup_table,
> --
> 2.16.0.rc1.238.g530d649a79-goog
>
