On 2018-01-22 07:01 PM, Michel Dänzer wrote: > On 2018-01-22 03:14 AM, Mario Kleiner wrote: >> Ok, 3rd revision, now with per-x-screen drmmode_crtc_funcs rec >> and set_gamma = NULL in the depth 30 case. Also back to Fredrik's >> original exa 10 bit patch, just with his signed-off tacked on. >> >> Tested with single and dual x-screen, depth 24, depth 30 and mixed >> 24 and 30 on separate x-screens. Also tested against current tip >> of ati-ddx master. > > Thanks for the thorough testing. > > The patches look mostly good now, apart from some cosmetic issues (lines > shouldn't be unnecessarily shorter than 72 columns, and acronyms should > be spelled in all upper case, in the commit logs), but I can live with > those. > > However, I gave the patches a quick spin (without a 30-bit capable > monitor though) on the Turks card that's currently sitting in my > development machine, and I noticed that Xorg crashes on shutdown because > the XvMC extension failed to initialize. Can you take a look? That turned out to be an xserver bug: https://patchwork.freedesktop.org/patch/200379/ So I pushed this series, thanks! -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
