On 2018-01-16 11:03 AM, Christian König wrote:
> Otherwise buffer placement is very restrictive and might fail.
>
> Fixes: "drm/amdgpu: fix VCE buffer placement restrictions v2"
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> Reported-by: Deng, Emily <Emily.Deng at amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> index 55a726a322e3..d274ae535530 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> @@ -585,8 +585,8 @@ static int amdgpu_vce_validate_bo(struct amdgpu_cs_parser *p, uint32_t ib_idx,
>
> for (i = 0; i < bo->placement.num_placement; ++i) {
> bo->placements[i].fpfn = max(bo->placements[i].fpfn, fpfn);
> - bo->placements[i].lpfn = bo->placements[i].fpfn ?
> - min(bo->placements[i].fpfn, lpfn) : lpfn;
> + bo->placements[i].lpfn = bo->placements[i].lpfn ?
> + min(bo->placements[i].lpfn, lpfn) : lpfn;
> }
> return ttm_bo_validate(&bo->tbo, &bo->placement, &ctx);
> }
>
Good catch.
Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
