Reviewed-by: Rex Zhu <Rex.Zhu at amd.com> and pushed the patch to drm-next. Best Regards Rex From: amd-gfx [mailto:amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf Of Deucher, Alexander Sent: Friday, January 05, 2018 12:09 AM To: Wentland, Harry; amd-gfx at lists.freedesktop.org; Tao, Yintian Subject: Re: [PATCH] drm/amd/powerplay: Fix no-cast warnings in smu7_smu_fini Acked-by: Alex Deucher <alexander.deucher at amd.com<mailto:alexander.deucher at amd.com>> ________________________________ From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx<mailto:amd-gfx-bounces at lists.freedesktop.org>> on behalf of Harry Wentland <harry.wentland at amd.com<mailto:harry.wentland at amd.com>> Sent: Thursday, January 4, 2018 11:01 AM To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>; Tao, Yintian Cc: Wentland, Harry Subject: [PATCH] drm/amd/powerplay: Fix no-cast warnings in smu7_smu_fini This fixes these warnings: drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu7_smumgr.c: In function 'smu7_smu_fini': drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu7_smumgr.c:653:33: warning: passing argument 2 of 'smu_free_memory' makes pointer from integer without a cast [-Wint-conversion] smu_free_memory(hwmgr->device, smu_data->header_buffer.handle); ^~~~~~~~ In file included from drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu7_smumgr.c:26:0: drivers/gpu/drm/amd/amdgpu/../powerplay/inc/smumgr.h:114:12: note: expected 'void *' but argument is of type 'long unsigned int' extern int smu_free_memory(void *device, void *handle); ^~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu7_smumgr.c:655:34: warning: passing argument 2 of 'smu_free_memory' makes pointer from integer without a cast [-Wint-conversion] smu_free_memory(hwmgr->device, smu_data->smu_buffer.handle); ^~~~~~~~ In file included from drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu7_smumgr.c:26:0: drivers/gpu/drm/amd/amdgpu/../powerplay/inc/smumgr.h:114:12: note: expected 'void *' but argument is of type 'long unsigned int' extern int smu_free_memory(void *device, void *handle); ^~~~~~~~~~~~~~~ Signed-off-by: Harry Wentland <harry.wentland at amd.com<mailto:harry.wentland at amd.com>> --- drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c index 25dd7781c9f2..311ff3718618 100644 --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c @@ -650,9 +650,9 @@ int smu7_smu_fini(struct pp_hwmgr *hwmgr) { struct smu7_smumgr *smu_data = (struct smu7_smumgr *)(hwmgr->smu_backend); - smu_free_memory(hwmgr->device, smu_data->header_buffer.handle); + smu_free_memory(hwmgr->device, (void *) smu_data->header_buffer.handle); if (!cgs_is_virtualization_enabled(hwmgr->device)) - smu_free_memory(hwmgr->device, smu_data->smu_buffer.handle); + smu_free_memory(hwmgr->device, (void *) smu_data->smu_buffer.handle); kfree(hwmgr->smu_backend); hwmgr->smu_backend = NULL; -- 2.14.1 _______________________________________________ amd-gfx mailing list amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180105/4e9268b0/attachment-0001.html>
