On 2018å¹´01æ??02æ?¥ 22:47, Christian König wrote: > We can actually handle invalid huge pages perfectly fine now. It seems be a bug fix for those valid no-huge-page ptes. Reviewed-by: Chunming Zhou <david1.zhou at amd.com> > > Signed-off-by: Christian König <christian.koenig at amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > index d4510807a692..3632c69f1814 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > @@ -950,11 +950,8 @@ static void amdgpu_vm_handle_huge_pages(struct amdgpu_pte_update_params *p, > uint64_t pd_addr, pde; > > /* In the case of a mixed PT the PDE must point to it*/ > - if (p->adev->asic_type < CHIP_VEGA10 || > - nptes != AMDGPU_VM_PTE_COUNT(p->adev) || > - p->src || > - !(flags & AMDGPU_PTE_VALID)) { > - > + if (p->adev->asic_type < CHIP_VEGA10 || p->src || > + nptes != AMDGPU_VM_PTE_COUNT(p->adev)) { > dst = amdgpu_bo_gpu_offset(entry->base.bo); > flags = AMDGPU_PTE_VALID; > } else {