My mean is like the attached, I revert part of yours. Regards, David zhou On 2017å¹´09æ??29æ?¥ 22:15, Marek Olšák wrote: > On Fri, Sep 29, 2017 at 4:13 PM, Marek Olšák <maraeo at gmail.com> wrote: >> On Fri, Sep 29, 2017 at 4:44 AM, Chunming Zhou <zhoucm1 at amd.com> wrote: >>> >>> On 2017å¹´09æ??13æ?¥ 04:42, Marek Olšák wrote: >>>> From: Marek Olšák <marek.olsak at amd.com> >>>> >>>> For amdgpu. >>>> >>>> drm_syncobj_create is renamed to drm_syncobj_create_as_handle, and new >>>> helpers drm_syncobj_create and drm_syncobj_get_handle are added. >>>> >>>> Signed-off-by: Marek Olšák <marek.olsak at amd.com> >>>> --- >>>> drivers/gpu/drm/drm_syncobj.c | 49 >>>> +++++++++++++++++++++++++++++++++++++++---- >>>> include/drm/drm_syncobj.h | 4 ++++ >>>> 2 files changed, 49 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c >>>> index 0422b8c..0bb1741 100644 >>>> --- a/drivers/gpu/drm/drm_syncobj.c >>>> +++ b/drivers/gpu/drm/drm_syncobj.c >>>> @@ -262,8 +262,14 @@ void drm_syncobj_free(struct kref *kref) >>>> } >>>> EXPORT_SYMBOL(drm_syncobj_free); >>>> -static int drm_syncobj_create(struct drm_file *file_private, >>>> - u32 *handle, uint32_t flags) >>> You can add a new parameter for passing dma fence, then in patch3, you can >>> directly use it for AMDGPU_FENCE_TO HANDLE_GET_SYNCOBJ. >>> >>> otherwise the set looks good to me. >> Sorry I just pushed this. > Actually, you commented on a deleted line. The function already has > dma_fence among the parameters. > > Marek -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-drm-Don-t-split-drm_syncobj_create.patch Type: text/x-patch Size: 4302 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170930/10df63f7/attachment-0001.bin>
