[PATCH] amdgpu/dc: add static to construct function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2017-09-27 07:21 PM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> There was a global construct symbol in the module symbols, kill it.
> 

Good catch. I should really watch out for global namespace pollution
which is really not cool in the kernel tree.

> Signed-off-by: Dave Airlie <airlied at redhat.com>

Reviewed-by: Harry Wentland <harry.wentland at amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c b/drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c
> index 7cce284..c627694 100644
> --- a/drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c
> +++ b/drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c
> @@ -406,7 +406,7 @@ static const struct irq_service_funcs irq_service_funcs_dce110 = {
>  		.to_dal_irq_source = to_dal_irq_source_dce110
>  };
>  
> -bool construct(
> +static bool construct(
>  	struct irq_service *irq_service,
>  	struct irq_service_init_data *init_data)
>  {
> 


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux