[PATCH] drm/amd/amdgpu: Fix iova debugfs for non-iommu case

tom.stdenis@xxxxxxx (Tom St Denis) · Tue, 19 Sep 2017 13:14:02 -0400

On 19/09/17 01:10 PM, Christian KÃ¶nig wrote:
> As far as I know we don't need #ifdefs cause there are dummy functions 
> when IOMMU is not compiled in.
> 
> But this patch is a NAK since it circumvents the /dev/mem restriction 
> when IOMMU is disabled and that is not something we can easily allow.

I raised this objection 24 hours ago and was told to go ahead with the 
read/write methods anyways.

Short of making a list of mappings/allocations in the ttm layer I have 
no idea how we would track this in the non-iommu case which means the 
entire iova debugfs entry should have been NAK'ed in the first place.

I'm open to suggestions.

Tom