NAK, that is intentionally separated and good coding style. See other DRM drivers as well. Regards, Christian. Am 19.09.2017 um 08:45 schrieb Xue, Ken: > drm/amdgpu: simplify trace point code > > amdgpu_trace_points.c does not declare license and it can be replaced by a simpler way. > > Signed-off-by: Ken Xue <Ken.Xue at amd.com> > --- > drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_trace_points.c | 9 --------- > 3 files changed, 3 insertions(+), 10 deletions(-) > delete mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_trace_points.c > > diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile b/drivers/gpu/drm/amd/amdgpu/Makefile > index 454e6ef..9d7db60 100644 > --- a/drivers/gpu/drm/amd/amdgpu/Makefile > +++ b/drivers/gpu/drm/amd/amdgpu/Makefile > @@ -26,7 +26,7 @@ amdgpu-y += amdgpu_device.o amdgpu_kms.o \ > amdgpu_encoders.o amdgpu_display.o amdgpu_i2c.o \ > amdgpu_fb.o amdgpu_gem.o amdgpu_ring.o \ > amdgpu_cs.o amdgpu_bios.o amdgpu_benchmark.o amdgpu_test.o \ > - amdgpu_pm.o atombios_dp.o amdgpu_afmt.o amdgpu_trace_points.o \ > + amdgpu_pm.o atombios_dp.o amdgpu_afmt.o \ > atombios_encoders.o amdgpu_sa.o atombios_i2c.o \ > amdgpu_prime.o amdgpu_vm.o amdgpu_ib.o amdgpu_pll.o \ > amdgpu_ucode.o amdgpu_bo_list.o amdgpu_ctx.o amdgpu_sync.o \ > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 7d365fa..8881ab3 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -37,7 +37,9 @@ > #include <linux/vga_switcheroo.h> > #include <linux/efi.h> > #include "amdgpu.h" > +#define CREATE_TRACE_POINTS > #include "amdgpu_trace.h" > +#undef CREATE_TRACE_POINTS > #include "amdgpu_i2c.h" > #include "atom.h" > #include "amdgpu_atombios.h" > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace_points.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace_points.c > deleted file mode 100644 > index 385b7e1..0000000 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace_points.c > +++ /dev/null > @@ -1,9 +0,0 @@ > -/* Copyright Red Hat Inc 2010. > - * Author : Dave Airlie <airlied at redhat.com> > - */ > -#include <drm/drmP.h> > -#include <drm/amdgpu_drm.h> > -#include "amdgpu.h" > - > -#define CREATE_TRACE_POINTS > -#include "amdgpu_trace.h" > -- > 2.7.4 > > > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
