On 11/09/17 03:46 AM, Christian König wrote: > Am 09.09.2017 um 12:49 schrieb Nicolai Hähnle: >> From: Nicolai Hähnle <nicolai.haehnle at amd.com> >> >> This is already hooked up to the "amdgpu_gpr" debugfs file used by >> the umr userspace debugging tool. >> >> Signed-off-by: Nicolai Hähnle <nicolai.haehnle at amd.com> > > Acked-by: Christian König <christian.koenig at amd.com> Reviewed-by: Tom St Denis <tom.stdenis at amd.com> Also I've tested it to the extent that I can read out data via umr on my Raven while running piglit. In an ideal world it'd be nice to have a known-answer-test where umr reads out SGPRS/VGPRS and we check against known values. Tom