Am 11.09.2017 um 02:55 schrieb Michel Dänzer: > On 09/09/17 12:52 AM, Christian König wrote: >> From: Christian König <christian.koenig at amd.com> >> >> Just some cleanup. >> >> Signed-off-by: Christian König <christian.koenig at amd.com> >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 25 +--------------- >> drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h | 52 ++++++++++++++++++++++++++++++++++ >> 2 files changed, 53 insertions(+), 24 deletions(-) >> create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h >> index 2bde315..a34c4cb 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h >> @@ -66,6 +66,7 @@ >> #include "amdgpu_vce.h" >> #include "amdgpu_vcn.h" >> #include "amdgpu_dm.h" >> +#include "amdgpu_mn.h" > It would be better to add this line in other files which actually > reference amdgpu_mn* instead of here. Yeah, that is the long term plan. But for the short term I want to decompose amdgpu.h into smaller and smaller parts first. Including the parts which are only needed by certain components is the next step then. > With that, and for patch 1 either way, > > Reviewed-by: Michel Dänzer <michel.daenzer at amd.com> Thanks, Christian.