On 2 September 2017 at 01:36, Marek Olšák <maraeo at gmail.com> wrote: > On Thu, Jul 6, 2017 at 3:17 AM, Dave Airlie <airlied at gmail.com> wrote: >> From: Dave Airlie <airlied at redhat.com> >> >> This adds kernel semaphore support to the command submission >> interface in what should be a backwards compatible manner, >> it adds a new command submission API. >> >> Signed-off-by: Dave Airlie <airlied at redhat.com> >> --- >> amdgpu/amdgpu.h | 29 ++++++++++++- >> amdgpu/amdgpu_cs.c | 118 +++++++++++++++++++++++++++++++++++++++++++++++++---- >> 2 files changed, 138 insertions(+), 9 deletions(-) >> >> diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h >> index 1901fa8..649b66e 100644 >> --- a/amdgpu/amdgpu.h >> +++ b/amdgpu/amdgpu.h >> @@ -369,6 +369,16 @@ struct amdgpu_cs_request { >> struct amdgpu_cs_fence_info fence_info; >> }; >> >> +struct amdgpu_cs_request_syncobj { >> + /* >> + * >> + */ > > Did you mean to fill in the comment here? > > Also, is this interface relevant with the raw CS API? This patch isn't required anymore. The raw CS interface replaced it. Dave.