Hi Trevor, I'm working on the VCE port side, which is pretty similar to UVD in many ways. I'll send some patches about this port soon, but I'll also need some RFC in the lot and help to get over hangs I hit with VCE rings. It's just not going as fast as I'd like, we had a baby a few months ago and my spare time is now mostly for her. ;) UVD was next on my to-do list, si I'd like to work with you on this because I think we could both get help from each others works. If I may suggest two things: try to segregate your work in a few patches instead of a big one. It is easier to review, comment, test and isolate problems. Also, about the header you added to the UVD firmware, this is one way to do it, or you could backport how it is done under radeon. This is the path I've chosen for now under VCE. I'll give a look at your patch. Cheers. -- Alexandre Demers