On 08/31/2017 08:53 PM, Tom St Denis wrote:
> Working on a series of tidy up patches for gfx_v9 and found this block in
> gfx_v9_0_sw_init().
>
> for (i = 0; i < adev->gfx.num_gfx_rings; i++) {
> ring = &adev->gfx.gfx_ring[i];
> ring->ring_obj = NULL;
> sprintf(ring->name, "gfx");
>
> Won't that make a series of rings all with the same name?
Yes, it will.
Generally we always have one gfx ring, so it's acceptable for now.
* adev->gfx.num_gfx_rings = GFX9_NUM_GFX_RINGS
Additionally, as all rings here belong to gfx, naming "gfx" also acceptable.
(Perhaps gfx[i] is a better name when we have more rings)
Regards,
Jerry
>
> Tom
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
