Hi Alex, Michel & Andrey, [PATCH] drm/amd/display: assign fb_location only if bo is pinned [PATCH 2/2] drm/amd/display: cleanup addReq and fix fb_location should be dropped and instead: [PATCH] drm/amd/display: fix high part address in dm_plane_helper_prepare_fb() should be reviewed . With this change I donâ??t have clean-up addReq, as I get the gpu_offset required for high part in dm_plane_helper_prepare_fb(). Thanks. Regards, Shirish S -----Original Message----- From: Michel Dänzer [mailto:michel@xxxxxxxxxxx] Sent: Wednesday, October 25, 2017 1:38 PM To: S, Shirish <Shirish.S at amd.com>; Grodzovsky, Andrey <Andrey.Grodzovsky at amd.com> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; amd-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org Subject: Re: [PATCH] drm/amd/display: assign fb_location only if bo is pinned On 25/10/17 07:18 AM, S, Shirish wrote: > > Andrey, > Till now the get_fb_info() never calculated fb_location(as addrReq was > always false), but since now its required to program the high part of > the address structure, > can you move it back into the commit scope and ensure that fb_location > is calculated everytime.(I have limited knowledge behind why it was > moved out) > And in case if you insist on adding pin & unpin in atomic_check() scope > i can post a patch for it. The latter on its own couldn't really solve the problem anyway: While a BO is unpinned, its MC address can change at any time. The MC address programmed to the hardware must be determined while the BO is and stays pinned. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
