[PATCH 2/2] drm/amd/display: cleanup addReq and fix fb_location

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





From: Shirish S <shirish.s@xxxxxxx>

The addReq attribute sent to fill_plane_attributes_from_fb()
is always false, hence fb_location is never set properly
causing issues in rendereing on underlay.

This patch cleans up the addReq attribute and hence fixes the issue.

Signed-off-by: Shirish S <shirish.s at amd.com>
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +++-----
  1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 1635372..2188f20 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -1771,8 +1771,7 @@ static int get_fb_info(const struct amdgpu_framebuffer *amdgpu_fb,
  
  static int fill_plane_attributes_from_fb(struct amdgpu_device *adev,
  					 struct dc_plane_state *plane_state,
-					 const struct amdgpu_framebuffer *amdgpu_fb,
-					 bool addReq)
+					 const struct amdgpu_framebuffer *amdgpu_fb)
  {
  	uint64_t tiling_flags;
  	uint64_t fb_location = 0;
@@ -1785,7 +1784,7 @@ static int fill_plane_attributes_from_fb(struct amdgpu_device *adev,
  	ret = get_fb_info(
  		amdgpu_fb,
  		&tiling_flags,
-		addReq == true ? &fb_location:NULL);
+		&fb_location);
  
  	if (ret)
  		return ret;
@@ -1970,8 +1969,7 @@ static int fill_plane_attributes(struct amdgpu_device *adev,
  	ret = fill_plane_attributes_from_fb(
  		crtc->dev->dev_private,
  		dc_plane_state,
-		amdgpu_fb,
-		addrReq);
+		amdgpu_fb);
  
  	if (ret)
  		return ret;
-- 
2.7.4



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux