Am 17.10.2017 16:59, schrieb Michel Dänzer: > On 17/10/17 04:53 PM, Harry Wentland wrote: >> On 2017-10-17 10:47 AM, Michel Dänzer wrote: >>> On 13/10/17 09:22 PM, Harry Wentland wrote: >>>> On 2017-10-12 08:22 PM, Dieter Nützel wrote: >>>>> >>>>> next (regression) compilation error: >>>>> >>>>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c: In >>>>> function â??resource_map_pool_resourcesâ??: >>>>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1688:14: >>>>> error: implicit declaration of function â??acquire_first_split_pipeâ??; >>>>> did you mean â??acquire_first_free_pipeâ??? >>>>> [-Werror=implicit-function-declaration] >>>>>   pipe_idx = acquire_first_split_pipe(&context->res_ctx, pool, >>>>> stream); >>>>>              ^~~~~~~~~~~~~~~~~~~~~~~~ >>>>>              acquire_first_free_pipe >>>>> >>>>> >>>>> It is wrongly (?) guarded behind: >>>>> >>>>> #if defined(CONFIG_DRM_AMD_DC_DCN1_0) >>>>> static int acquire_first_split_pipe( >>>>>                struct resource_context *res_ctx, >>>>>                const struct resource_pool *pool, >>>>>                struct dc_stream_state *stream) >>>>> [snip] >>>>> >>>> >>>> Sent and merged a patch. This function only makes sense for DCN and >>>> shouldn't >>>> be called otherwise. Thanks for reporting this. I gotta make sure to >>>> build >>>> without the DCN flag in the future to avoid this. >>> >>> Would it be possible to drop options like DRM_AMD_DC_FBC and >>> DRM_AMD_DC_DCN1_0 from amd-staging-drm-next (but especially >>> upstream), >>> and just always compile the code? >> >> DRM_AMD_DC_FBC should be pretty stable by now and can probably be >> dropped. >> I'll check with Roma who implemented it. > > Cool, thanks. I'm running my RX580 under 'amd-staging-drm-next' and 'drm-next-4.15-dc-wip' with it and don't see any problems so far. Greetings, Dieter
