On 2017-10-08 07:39 AM, Oded Gabbay wrote: > On Wed, Sep 27, 2017 at 7:09 AM, Felix Kuehling <Felix.Kuehling at amd.com> wrote: >> These patches cherry-pick most fixes, improvements and refactoring in >> the device queue manager from our internal branch. I squashed some >> patches that applied incremental fixes to the same code. Patch 5 is >> the extreme case that comes with a bunch of refactoring too. I think I >> squashed about a dozen patches by 5 authors that all overlapped and >> and applied incremental fixes and improvements to process termination >> handling. >> >> The last missing fixes in kfd_device_queue_manager.c are related to >> SDMA, which I'll leave for another patch series that also need changes >> in amdgpu. It will also add SDMA support for CZ. That's another 11 >> patches that I may be able to squash to 2 or 3. > Hi Felix, > Thanks for the patches. > I'm sorry for the delay in reviewing them. It's the month of the > holidays here so I have little time in front of a computer. I hope you enjoyed the holidays. Thanks for applying the patches. I've been busy working on the event handling code. I saw a lot of opportunity for cleanups and improvements and also had some internal feedback that event handling performance was slow with many signal events. I hope to have a patch series ready for review by the end of this week. After that I want to get back to SDMA support. Regards, Â Felix > > Oded > >> Felix Kuehling (4): >> drm/amdkfd: Fix MQD updates >> drm/amdkfd: Improve process termination handling in the queue manager >> drm/amdkfd: Clean up process queue management >> drm/amdkfd: Limit queue number per process and device to 127 >> >> Yong Zhao (4): >> drm/amdkfd: Avoid name confusion involved in queue unmapping >> drm/amdkfd: Simplify execute and unmap queue APIs >> drm/amdkfd: Avoid submitting an unnecessary packet to HWS >> drm/amdkfd: Compress unnecessary function parameters >> >> shaoyunl (1): >> drm/amdkfd: Improve multiple SDMA queues support per process >> >> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 3 +- >> drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c | 5 +- >> .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 376 ++++++++++++++------- >> .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.h | 5 + >> drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c | 27 +- >> drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 41 ++- >> drivers/gpu/drm/amd/amdkfd/kfd_process.c | 36 +- >> .../gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 62 ++-- >> 8 files changed, 348 insertions(+), 207 deletions(-) >> >> -- >> 2.7.4 >>