> -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Wednesday, October 04, 2017 1:49 PM > To: amd-gfx at lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH] drm/amd/powerplay: Partially revert changes and fix > smu7_notify_smc_display() > > This partially reverts 0b6b4cbf77c995a34a4ec3d705a636434dadc51a and fixes > the noise issues on Tonga. > > Signed-off-by: Tom St Denis <tom.stdenis at amd.com> Reviewed-by: Alex Deucher <alexander.deucher at amd.com> > --- > drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c > b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c > index 8dbe9148aad3..4826b2991b7e 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c > @@ -3825,14 +3825,11 @@ static int > smu7_notify_link_speed_change_after_state_change( > static int smu7_notify_smc_display(struct pp_hwmgr *hwmgr) > { > struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr- > >backend); > - int ret = 0; > > - if (hwmgr->feature_mask & PP_VBI_TIME_SUPPORT_MASK) { > + if (hwmgr->feature_mask & PP_VBI_TIME_SUPPORT_MASK) > smum_send_msg_to_smc_with_parameter(hwmgr, > (PPSMC_Msg)PPSMC_MSG_SetVBITimeout, data- > >frame_time_x2); > - ret = (smum_send_msg_to_smc(hwmgr, > (PPSMC_Msg)PPSMC_HasDisplay) == 0) ? 0 : -EINVAL; > - } > - return ret; > + return (smum_send_msg_to_smc(hwmgr, > (PPSMC_Msg)PPSMC_HasDisplay) == 0) ? 0 : -EINVAL; > } > > static int smu7_set_power_state_tasks(struct pp_hwmgr *hwmgr, const > void *input) > -- > 2.12.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
