On Mon, Nov 27, 2017 at 3:44 PM, Christian König <christian.koenig at amd.com> wrote: > Am 27.11.2017 um 21:01 schrieb Felix Kuehling: >> >> On 2017-11-27 02:37 PM, Koenig, Christian wrote: >>> >>> And that is a clear NAK to this approach. >> >> Hi Christian, >> >> Do you have other objections than the style issues? If so, please explain. > > > No, the technical aspect actually looks rather reasonable. > >> Please clarify, why this file needs to be treated differently from other >> files under include/asic_reg? All those files are auto-generated by HW >> teams. Fixing the coding style adds no value and makes future updates >> more complicated. > > > We already got complains about that and most likely will need to fix the > rest as well. I'd like to stay as close as possible to the headers formats we are using internally across teams for consistency. Rather than rewriting these now, how about we just rename soc15ip.h to vg10ip.h and use that or even just drop patch 1 and use soc15ip.h as is for now. Alex > > Nicolai looked into using a different auto generator for the header files, > but not sure how far that already got along. > > The point is that the structures added with this won't be used by soc15 > alone, but rather be the base of the new register definition for future > hardware generations as well. > >> Like Shaoyun pointed out for example, the existing file >> include/asic_reg/vega10/soc15ip.h has the same style issues. > > > That file actually doesn't exists any more. Please see the work from Feifei > about that as well. > > Regards, > Christian. > >> >> Regards, >> Felix >> >>> Please start by fixing at least the obvious style problems before >>> resending. >>> >>> Thanks, >>> Christian. >>> >>> Am 27.11.2017 20:29 schrieb "Liu, Shaoyun" <Shaoyun.Liu at amd.com>: >>> >>> I agree that this HW engineer generated file doesn't match the >>> coding style from linux software engineer point of view , but >>> since we already import other similar " HW engineer style" files >>> under include/asic_reg/vega10/, I don't see a reason to specially >>> change this file without touch else . This file is actually almost >>> identical as soc15ip.h . I think it's easier for us to import >>> other offset file in the future if we keep them un-touched . >>> >>> Regards >>> Shaoyun.liu >>> >>> >>> -----Original Message----- >>> From: Christian König [mailto:ckoenig.leichtzumerken at gmail.com] >>> Sent: Monday, November 27, 2017 2:17 PM >>> To: Liu, Shaoyun; amd-gfx at lists.freedesktop.org >>> Subject: Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file >>> >>> First of let us fix the obvious style problems. >>> >>> Am 27.11.2017 um 19:30 schrieb Shaoyun Liu: >>> > Change-Id: I654d02891b80f3457ddcd80d6a8ea5ace295a89c >>> > Signed-off-by: Shaoyun Liu <Shaoyun.Liu at amd.com> >>> > --- >>> > .../drm/amd/include/asic_reg/vega10/ip_offset_1.h | 1248 >>> ++++++++++++++++++++ >>> > 1 file changed, 1248 insertions(+) >>> > create mode 100644 >>> drivers/gpu/drm/amd/include/asic_reg/vega10/ip_offset_1.h >>> > >>> > diff --git >>> a/drivers/gpu/drm/amd/include/asic_reg/vega10/ip_offset_1.h >>> b/drivers/gpu/drm/amd/include/asic_reg/vega10/ip_offset_1.h >>> > new file mode 100644 >>> > index 0000000..76cb748 >>> > --- /dev/null >>> > +++ b/drivers/gpu/drm/amd/include/asic_reg/vega10/ip_offset_1.h >>> > @@ -0,0 +1,1248 @@ >>> > +#ifndef _ip_offset_1_HEADER >>> > +#define _ip_offset_1_HEADER >>> Names for preprocessor defines should be capitable. >>> >>> > + >>> > +#define MAX_INSTANCE 5 >>> > +#define MAX_SEGMENT 5 >>> > + >>> > + >>> > +struct IP_BASE_INSTANCE >>> >>> Structure names should be lower case. And we need an amdgpu_ or at >>> least >>> amd_ prefix here. >>> >>> Regards, >>> Christian. >>> >>> > +{ >>> > + unsigned int segment[MAX_SEGMENT]; >>> > +}; >>> > + >>> > +struct IP_BASE >>> > +{ >>> > + struct IP_BASE_INSTANCE instance[MAX_INSTANCE]; >>> > +}; >>> > + >>> > + >>> > +static const struct IP_BASE NBIF_BASE = >>> { { { { 0x00000000, 0x00000014, 0x00000D20, 0x00010400, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE NBIO_BASE = >>> { { { { 0x00000000, 0x00000014, 0x00000D20, 0x00010400, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE DCE_BASE = { { { { >>> 0x00000012, 0x000000C0, 0x000034C0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE DCN_BASE = { { { { >>> 0x00000012, 0x000000C0, 0x000034C0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE MP0_BASE = { { { { >>> 0x00016000, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE MP1_BASE = { { { { >>> 0x00016000, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE MP2_BASE = { { { { >>> 0x00016000, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE DF_BASE = { { { { >>> 0x00007000, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE UVD_BASE = { { { { >>> 0x00007800, 0x00007E00, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; //note: GLN does not use the first >>> segment >>> >>> No "//" in kernel code please. >>> >>> > +static const struct IP_BASE VCN_BASE = { { { { >>> 0x00007800, 0x00007E00, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; //note: GLN does not use the first >>> segment >>> > +static const struct IP_BASE DBGU_BASE = >>> { { { { 0x00000180, 0x000001A0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; // not exist >>> > +static const struct IP_BASE DBGU_NBIO_BASE = { { { { >>> 0x000001C0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; // not exist >>> > +static const struct IP_BASE DBGU_IO_BASE = { { { { >>> 0x000001E0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; // not exist >>> > +static const struct IP_BASE DFX_DAP_BASE = { { { { >>> 0x000005A0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; // not exist >>> > +static const struct IP_BASE DFX_BASE = { { { { >>> 0x00000580, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; // this file does not contain registers >>> > +static const struct IP_BASE ISP_BASE = { { { { >>> 0x00018000, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; // not exist >>> > +static const struct IP_BASE SYSTEMHUB_BASE = { { { { >>> 0x00000EA0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; // not exist >>> > +static const struct IP_BASE L2IMU_BASE = >>> { { { { 0x00007DC0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE IOHC_BASE = >>> { { { { 0x00010000, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE ATHUB_BASE = >>> { { { { 0x00000C20, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE VCE_BASE = { { { { >>> 0x00007E00, 0x00048800, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE GC_BASE = { { { { >>> 0x00002000, 0x0000A000, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE MMHUB_BASE = >>> { { { { 0x0001A000, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE RSMU_BASE = >>> { { { { 0x00012000, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE HDP_BASE = { { { { >>> 0x00000F20, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE OSSSYS_BASE = { { { { >>> 0x000010A0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE SDMA0_BASE = >>> { { { { 0x00001260, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE SDMA1_BASE = >>> { { { { 0x00001460, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE XDMA_BASE = >>> { { { { 0x00003400, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE UMC_BASE = { { { { >>> 0x00014000, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE THM_BASE = { { { { >>> 0x00016600, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE SMUIO_BASE = >>> { { { { 0x00016800, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE PWR_BASE = { { { { >>> 0x00016A00, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE CLK_BASE = { { { { >>> 0x00016C00, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0x00016E00, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0x00017000, 0, 0, 0, 0 } }, >>> > + { { 0x00017200, 0, 0, >>> 0, 0 } }, >>> > + { >>> { 0x00017E00, 0, 0, 0, 0 } } } }; >>> > +static const struct IP_BASE FUSE_BASE = >>> { { { { 0x00017400, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } }, >>> > >>> + >>> { { 0, 0, 0, 0, 0 } } } }; >>> > + >>> > + >>> > +#define NBIF_BASE__INST0_SEG0 0x00000000 >>> > +#define NBIF_BASE__INST0_SEG1 0x00000014 >>> > +#define NBIF_BASE__INST0_SEG2 0x00000D20 >>> > +#define NBIF_BASE__INST0_SEG3 0x00010400 >>> > +#define NBIF_BASE__INST0_SEG4 0 >>> > + >>> > +#define NBIF_BASE__INST1_SEG0 0 >>> > +#define NBIF_BASE__INST1_SEG1 0 >>> > +#define NBIF_BASE__INST1_SEG2 0 >>> > +#define NBIF_BASE__INST1_SEG3 0 >>> > +#define NBIF_BASE__INST1_SEG4 0 >>> > + >>> > +#define NBIF_BASE__INST2_SEG0 0 >>> > +#define NBIF_BASE__INST2_SEG1 0 >>> > +#define NBIF_BASE__INST2_SEG2 0 >>> > +#define NBIF_BASE__INST2_SEG3 0 >>> > +#define NBIF_BASE__INST2_SEG4 0 >>> > + >>> > +#define NBIF_BASE__INST3_SEG0 0 >>> > +#define NBIF_BASE__INST3_SEG1 0 >>> > +#define NBIF_BASE__INST3_SEG2 0 >>> > +#define NBIF_BASE__INST3_SEG3 0 >>> > +#define NBIF_BASE__INST3_SEG4 0 >>> > + >>> > +#define NBIF_BASE__INST4_SEG0 0 >>> > +#define NBIF_BASE__INST4_SEG1 0 >>> > +#define NBIF_BASE__INST4_SEG2 0 >>> > +#define NBIF_BASE__INST4_SEG3 0 >>> > +#define NBIF_BASE__INST4_SEG4 0 >>> > + >>> > +#define NBIO_BASE__INST0_SEG0 0x00000000 >>> > +#define NBIO_BASE__INST0_SEG1 0x00000014 >>> > +#define NBIO_BASE__INST0_SEG2 0x00000D20 >>> > +#define NBIO_BASE__INST0_SEG3 0x00010400 >>> > +#define NBIO_BASE__INST0_SEG4 0 >>> > + >>> > +#define NBIO_BASE__INST1_SEG0 0 >>> > +#define NBIO_BASE__INST1_SEG1 0 >>> > +#define NBIO_BASE__INST1_SEG2 0 >>> > +#define NBIO_BASE__INST1_SEG3 0 >>> > +#define NBIO_BASE__INST1_SEG4 0 >>> > + >>> > +#define NBIO_BASE__INST2_SEG0 0 >>> > +#define NBIO_BASE__INST2_SEG1 0 >>> > +#define NBIO_BASE__INST2_SEG2 0 >>> > +#define NBIO_BASE__INST2_SEG3 0 >>> > +#define NBIO_BASE__INST2_SEG4 0 >>> > + >>> > +#define NBIO_BASE__INST3_SEG0 0 >>> > +#define NBIO_BASE__INST3_SEG1 0 >>> > +#define NBIO_BASE__INST3_SEG2 0 >>> > +#define NBIO_BASE__INST3_SEG3 0 >>> > +#define NBIO_BASE__INST3_SEG4 0 >>> > + >>> > +#define NBIO_BASE__INST4_SEG0 0 >>> > +#define NBIO_BASE__INST4_SEG1 0 >>> > +#define NBIO_BASE__INST4_SEG2 0 >>> > +#define NBIO_BASE__INST4_SEG3 0 >>> > +#define NBIO_BASE__INST4_SEG4 0 >>> > + >>> > +#define DCE_BASE__INST0_SEG0 0x00000012 >>> > +#define DCE_BASE__INST0_SEG1 0x000000C0 >>> > +#define DCE_BASE__INST0_SEG2 0x000034C0 >>> > +#define DCE_BASE__INST0_SEG3 0 >>> > +#define DCE_BASE__INST0_SEG4 0 >>> > + >>> > +#define DCE_BASE__INST1_SEG0 0 >>> > +#define DCE_BASE__INST1_SEG1 0 >>> > +#define DCE_BASE__INST1_SEG2 0 >>> > +#define DCE_BASE__INST1_SEG3 0 >>> > +#define DCE_BASE__INST1_SEG4 0 >>> > + >>> > +#define DCE_BASE__INST2_SEG0 0 >>> > +#define DCE_BASE__INST2_SEG1 0 >>> > +#define DCE_BASE__INST2_SEG2 0 >>> > +#define DCE_BASE__INST2_SEG3 0 >>> > +#define DCE_BASE__INST2_SEG4 0 >>> > + >>> > +#define DCE_BASE__INST3_SEG0 0 >>> > +#define DCE_BASE__INST3_SEG1 0 >>> > +#define DCE_BASE__INST3_SEG2 0 >>> > +#define DCE_BASE__INST3_SEG3 0 >>> > +#define DCE_BASE__INST3_SEG4 0 >>> > + >>> > +#define DCE_BASE__INST4_SEG0 0 >>> > +#define DCE_BASE__INST4_SEG1 0 >>> > +#define DCE_BASE__INST4_SEG2 0 >>> > +#define DCE_BASE__INST4_SEG3 0 >>> > +#define DCE_BASE__INST4_SEG4 0 >>> > + >>> > +#define DCN_BASE__INST0_SEG0 0x00000012 >>> > +#define DCN_BASE__INST0_SEG1 0x000000C0 >>> > +#define DCN_BASE__INST0_SEG2 0x000034C0 >>> > +#define DCN_BASE__INST0_SEG3 0 >>> > +#define DCN_BASE__INST0_SEG4 0 >>> > + >>> > +#define DCN_BASE__INST1_SEG0 0 >>> > +#define DCN_BASE__INST1_SEG1 0 >>> > +#define DCN_BASE__INST1_SEG2 0 >>> > +#define DCN_BASE__INST1_SEG3 0 >>> > +#define DCN_BASE__INST1_SEG4 0 >>> > + >>> > +#define DCN_BASE__INST2_SEG0 0 >>> > +#define DCN_BASE__INST2_SEG1 0 >>> > +#define DCN_BASE__INST2_SEG2 0 >>> > +#define DCN_BASE__INST2_SEG3 0 >>> > +#define DCN_BASE__INST2_SEG4 0 >>> > + >>> > +#define DCN_BASE__INST3_SEG0 0 >>> > +#define DCN_BASE__INST3_SEG1 0 >>> > +#define DCN_BASE__INST3_SEG2 0 >>> > +#define DCN_BASE__INST3_SEG3 0 >>> > +#define DCN_BASE__INST3_SEG4 0 >>> > + >>> > +#define DCN_BASE__INST4_SEG0 0 >>> > +#define DCN_BASE__INST4_SEG1 0 >>> > +#define DCN_BASE__INST4_SEG2 0 >>> > +#define DCN_BASE__INST4_SEG3 0 >>> > +#define DCN_BASE__INST4_SEG4 0 >>> > + >>> > +#define MP0_BASE__INST0_SEG0 0x00016000 >>> > +#define MP0_BASE__INST0_SEG1 0 >>> > +#define MP0_BASE__INST0_SEG2 0 >>> > +#define MP0_BASE__INST0_SEG3 0 >>> > +#define MP0_BASE__INST0_SEG4 0 >>> > + >>> > +#define MP0_BASE__INST1_SEG0 0 >>> > +#define MP0_BASE__INST1_SEG1 0 >>> > +#define MP0_BASE__INST1_SEG2 0 >>> > +#define MP0_BASE__INST1_SEG3 0 >>> > +#define MP0_BASE__INST1_SEG4 0 >>> > + >>> > +#define MP0_BASE__INST2_SEG0 0 >>> > +#define MP0_BASE__INST2_SEG1 0 >>> > +#define MP0_BASE__INST2_SEG2 0 >>> > +#define MP0_BASE__INST2_SEG3 0 >>> > +#define MP0_BASE__INST2_SEG4 0 >>> > + >>> > +#define MP0_BASE__INST3_SEG0 0 >>> > +#define MP0_BASE__INST3_SEG1 0 >>> > +#define MP0_BASE__INST3_SEG2 0 >>> > +#define MP0_BASE__INST3_SEG3 0 >>> > +#define MP0_BASE__INST3_SEG4 0 >>> > + >>> > +#define MP0_BASE__INST4_SEG0 0 >>> > +#define MP0_BASE__INST4_SEG1 0 >>> > +#define MP0_BASE__INST4_SEG2 0 >>> > +#define MP0_BASE__INST4_SEG3 0 >>> > +#define MP0_BASE__INST4_SEG4 0 >>> > + >>> > +#define MP1_BASE__INST0_SEG0 0x00016000 >>> > +#define MP1_BASE__INST0_SEG1 0 >>> > +#define MP1_BASE__INST0_SEG2 0 >>> > +#define MP1_BASE__INST0_SEG3 0 >>> > +#define MP1_BASE__INST0_SEG4 0 >>> > + >>> > +#define MP1_BASE__INST1_SEG0 0 >>> > +#define MP1_BASE__INST1_SEG1 0 >>> > +#define MP1_BASE__INST1_SEG2 0 >>> > +#define MP1_BASE__INST1_SEG3 0 >>> > +#define MP1_BASE__INST1_SEG4 0 >>> > + >>> > +#define MP1_BASE__INST2_SEG0 0 >>> > +#define MP1_BASE__INST2_SEG1 0 >>> > +#define MP1_BASE__INST2_SEG2 0 >>> > +#define MP1_BASE__INST2_SEG3 0 >>> > +#define MP1_BASE__INST2_SEG4 0 >>> > + >>> > +#define MP1_BASE__INST3_SEG0 0 >>> > +#define MP1_BASE__INST3_SEG1 0 >>> > +#define MP1_BASE__INST3_SEG2 0 >>> > +#define MP1_BASE__INST3_SEG3 0 >>> > +#define MP1_BASE__INST3_SEG4 0 >>> > + >>> > +#define MP1_BASE__INST4_SEG0 0 >>> > +#define MP1_BASE__INST4_SEG1 0 >>> > +#define MP1_BASE__INST4_SEG2 0 >>> > +#define MP1_BASE__INST4_SEG3 0 >>> > +#define MP1_BASE__INST4_SEG4 0 >>> > + >>> > +#define MP2_BASE__INST0_SEG0 0x00016000 >>> > +#define MP2_BASE__INST0_SEG1 0 >>> > +#define MP2_BASE__INST0_SEG2 0 >>> > +#define MP2_BASE__INST0_SEG3 0 >>> > +#define MP2_BASE__INST0_SEG4 0 >>> > + >>> > +#define MP2_BASE__INST1_SEG0 0 >>> > +#define MP2_BASE__INST1_SEG1 0 >>> > +#define MP2_BASE__INST1_SEG2 0 >>> > +#define MP2_BASE__INST1_SEG3 0 >>> > +#define MP2_BASE__INST1_SEG4 0 >>> > + >>> > +#define MP2_BASE__INST2_SEG0 0 >>> > +#define MP2_BASE__INST2_SEG1 0 >>> > +#define MP2_BASE__INST2_SEG2 0 >>> > +#define MP2_BASE__INST2_SEG3 0 >>> > +#define MP2_BASE__INST2_SEG4 0 >>> > + >>> > +#define MP2_BASE__INST3_SEG0 0 >>> > +#define MP2_BASE__INST3_SEG1 0 >>> > +#define MP2_BASE__INST3_SEG2 0 >>> > +#define MP2_BASE__INST3_SEG3 0 >>> > +#define MP2_BASE__INST3_SEG4 0 >>> > + >>> > +#define MP2_BASE__INST4_SEG0 0 >>> > +#define MP2_BASE__INST4_SEG1 0 >>> > +#define MP2_BASE__INST4_SEG2 0 >>> > +#define MP2_BASE__INST4_SEG3 0 >>> > +#define MP2_BASE__INST4_SEG4 0 >>> > + >>> > +#define DF_BASE__INST0_SEG0 0x00007000 >>> > +#define DF_BASE__INST0_SEG1 0 >>> > +#define DF_BASE__INST0_SEG2 0 >>> > +#define DF_BASE__INST0_SEG3 0 >>> > +#define DF_BASE__INST0_SEG4 0 >>> > + >>> > +#define DF_BASE__INST1_SEG0 0 >>> > +#define DF_BASE__INST1_SEG1 0 >>> > +#define DF_BASE__INST1_SEG2 0 >>> > +#define DF_BASE__INST1_SEG3 0 >>> > +#define DF_BASE__INST1_SEG4 0 >>> > + >>> > +#define DF_BASE__INST2_SEG0 0 >>> > +#define DF_BASE__INST2_SEG1 0 >>> > +#define DF_BASE__INST2_SEG2 0 >>> > +#define DF_BASE__INST2_SEG3 0 >>> > +#define DF_BASE__INST2_SEG4 0 >>> > + >>> > +#define DF_BASE__INST3_SEG0 0 >>> > +#define DF_BASE__INST3_SEG1 0 >>> > +#define DF_BASE__INST3_SEG2 0 >>> > +#define DF_BASE__INST3_SEG3 0 >>> > +#define DF_BASE__INST3_SEG4 0 >>> > + >>> > +#define DF_BASE__INST4_SEG0 0 >>> > +#define DF_BASE__INST4_SEG1 0 >>> > +#define DF_BASE__INST4_SEG2 0 >>> > +#define DF_BASE__INST4_SEG3 0 >>> > +#define DF_BASE__INST4_SEG4 0 >>> > + >>> > +#define UVD_BASE__INST0_SEG0 0x00007800 >>> > +#define UVD_BASE__INST0_SEG1 0x00007E00 >>> > +#define UVD_BASE__INST0_SEG2 0 >>> > +#define UVD_BASE__INST0_SEG3 0 >>> > +#define UVD_BASE__INST0_SEG4 0 >>> > + >>> > +#define UVD_BASE__INST1_SEG0 0 >>> > +#define UVD_BASE__INST1_SEG1 0 >>> > +#define UVD_BASE__INST1_SEG2 0 >>> > +#define UVD_BASE__INST1_SEG3 0 >>> > +#define UVD_BASE__INST1_SEG4 0 >>> > + >>> > +#define UVD_BASE__INST2_SEG0 0 >>> > +#define UVD_BASE__INST2_SEG1 0 >>> > +#define UVD_BASE__INST2_SEG2 0 >>> > +#define UVD_BASE__INST2_SEG3 0 >>> > +#define UVD_BASE__INST2_SEG4 0 >>> > + >>> > +#define UVD_BASE__INST3_SEG0 0 >>> > +#define UVD_BASE__INST3_SEG1 0 >>> > +#define UVD_BASE__INST3_SEG2 0 >>> > +#define UVD_BASE__INST3_SEG3 0 >>> > +#define UVD_BASE__INST3_SEG4 0 >>> > + >>> > +#define UVD_BASE__INST4_SEG0 0 >>> > +#define UVD_BASE__INST4_SEG1 0 >>> > +#define UVD_BASE__INST4_SEG2 0 >>> > +#define UVD_BASE__INST4_SEG3 0 >>> > +#define UVD_BASE__INST4_SEG4 0 >>> > + >>> > +#define VCN_BASE__INST0_SEG0 0x00007800 >>> > +#define VCN_BASE__INST0_SEG1 0x00007E00 >>> > +#define VCN_BASE__INST0_SEG2 0 >>> > +#define VCN_BASE__INST0_SEG3 0 >>> > +#define VCN_BASE__INST0_SEG4 0 >>> > + >>> > +#define VCN_BASE__INST1_SEG0 0 >>> > +#define VCN_BASE__INST1_SEG1 0 >>> > +#define VCN_BASE__INST1_SEG2 0 >>> > +#define VCN_BASE__INST1_SEG3 0 >>> > +#define VCN_BASE__INST1_SEG4 0 >>> > + >>> > +#define VCN_BASE__INST2_SEG0 0 >>> > +#define VCN_BASE__INST2_SEG1 0 >>> > +#define VCN_BASE__INST2_SEG2 0 >>> > +#define VCN_BASE__INST2_SEG3 0 >>> > +#define VCN_BASE__INST2_SEG4 0 >>> > + >>> > +#define VCN_BASE__INST3_SEG0 0 >>> > +#define VCN_BASE__INST3_SEG1 0 >>> > +#define VCN_BASE__INST3_SEG2 0 >>> > +#define VCN_BASE__INST3_SEG3 0 >>> > +#define VCN_BASE__INST3_SEG4 0 >>> > + >>> > +#define VCN_BASE__INST4_SEG0 0 >>> > +#define VCN_BASE__INST4_SEG1 0 >>> > +#define VCN_BASE__INST4_SEG2 0 >>> > +#define VCN_BASE__INST4_SEG3 0 >>> > +#define VCN_BASE__INST4_SEG4 0 >>> > + >>> > +#define DBGU_BASE__INST0_SEG0 0x00000180 >>> > +#define DBGU_BASE__INST0_SEG1 0x000001A0 >>> > +#define DBGU_BASE__INST0_SEG2 0 >>> > +#define DBGU_BASE__INST0_SEG3 0 >>> > +#define DBGU_BASE__INST0_SEG4 0 >>> > + >>> > +#define DBGU_BASE__INST1_SEG0 0 >>> > +#define DBGU_BASE__INST1_SEG1 0 >>> > +#define DBGU_BASE__INST1_SEG2 0 >>> > +#define DBGU_BASE__INST1_SEG3 0 >>> > +#define DBGU_BASE__INST1_SEG4 0 >>> > + >>> > +#define DBGU_BASE__INST2_SEG0 0 >>> > +#define DBGU_BASE__INST2_SEG1 0 >>> > +#define DBGU_BASE__INST2_SEG2 0 >>> > +#define DBGU_BASE__INST2_SEG3 0 >>> > +#define DBGU_BASE__INST2_SEG4 0 >>> > + >>> > +#define DBGU_BASE__INST3_SEG0 0 >>> > +#define DBGU_BASE__INST3_SEG1 0 >>> > +#define DBGU_BASE__INST3_SEG2 0 >>> > +#define DBGU_BASE__INST3_SEG3 0 >>> > +#define DBGU_BASE__INST3_SEG4 0 >>> > + >>> > +#define DBGU_BASE__INST4_SEG0 0 >>> > +#define DBGU_BASE__INST4_SEG1 0 >>> > +#define DBGU_BASE__INST4_SEG2 0 >>> > +#define DBGU_BASE__INST4_SEG3 0 >>> > +#define DBGU_BASE__INST4_SEG4 0 >>> > + >>> > +#define DBGU_NBIO_BASE__INST0_SEG0 0x000001C0 >>> > +#define DBGU_NBIO_BASE__INST0_SEG1 0 >>> > +#define DBGU_NBIO_BASE__INST0_SEG2 0 >>> > +#define DBGU_NBIO_BASE__INST0_SEG3 0 >>> > +#define DBGU_NBIO_BASE__INST0_SEG4 0 >>> > + >>> > +#define DBGU_NBIO_BASE__INST1_SEG0 0 >>> > +#define DBGU_NBIO_BASE__INST1_SEG1 0 >>> > +#define DBGU_NBIO_BASE__INST1_SEG2 0 >>> > +#define DBGU_NBIO_BASE__INST1_SEG3 0 >>> > +#define DBGU_NBIO_BASE__INST1_SEG4 0 >>> > + >>> > +#define DBGU_NBIO_BASE__INST2_SEG0 0 >>> > +#define DBGU_NBIO_BASE__INST2_SEG1 0 >>> > +#define DBGU_NBIO_BASE__INST2_SEG2 0 >>> > +#define DBGU_NBIO_BASE__INST2_SEG3 0 >>> > +#define DBGU_NBIO_BASE__INST2_SEG4 0 >>> > + >>> > +#define DBGU_NBIO_BASE__INST3_SEG0 0 >>> > +#define DBGU_NBIO_BASE__INST3_SEG1 0 >>> > +#define DBGU_NBIO_BASE__INST3_SEG2 0 >>> > +#define DBGU_NBIO_BASE__INST3_SEG3 0 >>> > +#define DBGU_NBIO_BASE__INST3_SEG4 0 >>> > + >>> > +#define DBGU_NBIO_BASE__INST4_SEG0 0 >>> > +#define DBGU_NBIO_BASE__INST4_SEG1 0 >>> > +#define DBGU_NBIO_BASE__INST4_SEG2 0 >>> > +#define DBGU_NBIO_BASE__INST4_SEG3 0 >>> > +#define DBGU_NBIO_BASE__INST4_SEG4 0 >>> > + >>> > +#define DBGU_IO_BASE__INST0_SEG0 0x000001E0 >>> > +#define DBGU_IO_BASE__INST0_SEG1 0 >>> > +#define DBGU_IO_BASE__INST0_SEG2 0 >>> > +#define DBGU_IO_BASE__INST0_SEG3 0 >>> > +#define DBGU_IO_BASE__INST0_SEG4 0 >>> > + >>> > +#define DBGU_IO_BASE__INST1_SEG0 0 >>> > +#define DBGU_IO_BASE__INST1_SEG1 0 >>> > +#define DBGU_IO_BASE__INST1_SEG2 0 >>> > +#define DBGU_IO_BASE__INST1_SEG3 0 >>> > +#define DBGU_IO_BASE__INST1_SEG4 0 >>> > + >>> > +#define DBGU_IO_BASE__INST2_SEG0 0 >>> > +#define DBGU_IO_BASE__INST2_SEG1 0 >>> > +#define DBGU_IO_BASE__INST2_SEG2 0 >>> > +#define DBGU_IO_BASE__INST2_SEG3 0 >>> > +#define DBGU_IO_BASE__INST2_SEG4 0 >>> > + >>> > +#define DBGU_IO_BASE__INST3_SEG0 0 >>> > +#define DBGU_IO_BASE__INST3_SEG1 0 >>> > +#define DBGU_IO_BASE__INST3_SEG2 0 >>> > +#define DBGU_IO_BASE__INST3_SEG3 0 >>> > +#define DBGU_IO_BASE__INST3_SEG4 0 >>> > + >>> > +#define DBGU_IO_BASE__INST4_SEG0 0 >>> > +#define DBGU_IO_BASE__INST4_SEG1 0 >>> > +#define DBGU_IO_BASE__INST4_SEG2 0 >>> > +#define DBGU_IO_BASE__INST4_SEG3 0 >>> > +#define DBGU_IO_BASE__INST4_SEG4 0 >>> > + >>> > +#define DFX_DAP_BASE__INST0_SEG0 0x000005A0 >>> > +#define DFX_DAP_BASE__INST0_SEG1 0 >>> > +#define DFX_DAP_BASE__INST0_SEG2 0 >>> > +#define DFX_DAP_BASE__INST0_SEG3 0 >>> > +#define DFX_DAP_BASE__INST0_SEG4 0 >>> > + >>> > +#define DFX_DAP_BASE__INST1_SEG0 0 >>> > +#define DFX_DAP_BASE__INST1_SEG1 0 >>> > +#define DFX_DAP_BASE__INST1_SEG2 0 >>> > +#define DFX_DAP_BASE__INST1_SEG3 0 >>> > +#define DFX_DAP_BASE__INST1_SEG4 0 >>> > + >>> > +#define DFX_DAP_BASE__INST2_SEG0 0 >>> > +#define DFX_DAP_BASE__INST2_SEG1 0 >>> > +#define DFX_DAP_BASE__INST2_SEG2 0 >>> > +#define DFX_DAP_BASE__INST2_SEG3 0 >>> > +#define DFX_DAP_BASE__INST2_SEG4 0 >>> > + >>> > +#define DFX_DAP_BASE__INST3_SEG0 0 >>> > +#define DFX_DAP_BASE__INST3_SEG1 0 >>> > +#define DFX_DAP_BASE__INST3_SEG2 0 >>> > +#define DFX_DAP_BASE__INST3_SEG3 0 >>> > +#define DFX_DAP_BASE__INST3_SEG4 0 >>> > + >>> > +#define DFX_DAP_BASE__INST4_SEG0 0 >>> > +#define DFX_DAP_BASE__INST4_SEG1 0 >>> > +#define DFX_DAP_BASE__INST4_SEG2 0 >>> > +#define DFX_DAP_BASE__INST4_SEG3 0 >>> > +#define DFX_DAP_BASE__INST4_SEG4 0 >>> > + >>> > +#define DFX_BASE__INST0_SEG0 0x00000580 >>> > +#define DFX_BASE__INST0_SEG1 0 >>> > +#define DFX_BASE__INST0_SEG2 0 >>> > +#define DFX_BASE__INST0_SEG3 0 >>> > +#define DFX_BASE__INST0_SEG4 0 >>> > + >>> > +#define DFX_BASE__INST1_SEG0 0 >>> > +#define DFX_BASE__INST1_SEG1 0 >>> > +#define DFX_BASE__INST1_SEG2 0 >>> > +#define DFX_BASE__INST1_SEG3 0 >>> > +#define DFX_BASE__INST1_SEG4 0 >>> > + >>> > +#define DFX_BASE__INST2_SEG0 0 >>> > +#define DFX_BASE__INST2_SEG1 0 >>> > +#define DFX_BASE__INST2_SEG2 0 >>> > +#define DFX_BASE__INST2_SEG3 0 >>> > +#define DFX_BASE__INST2_SEG4 0 >>> > + >>> > +#define DFX_BASE__INST3_SEG0 0 >>> > +#define DFX_BASE__INST3_SEG1 0 >>> > +#define DFX_BASE__INST3_SEG2 0 >>> > +#define DFX_BASE__INST3_SEG3 0
