I got it, the IH sw_fini is done later than DCE while your other patch cleans up timer in DCE sw_fini.
Maybe you can call amdgpu_irq_put() here, anyway your patch is already in:)
â??
Sincerely Yours,
Pixel
On 16/11/2017, 5:28 PM, "Ding, Pixel" <Pixel.Ding at amd.com> wrote:
>Hi Monk,
>
>Iâ??m not for sure what issue you are fixing. The timer should be cancelled while the IRQ is put to disable vblank . However there is a known rmmod issue fixed with â??02d319e drm/amdgpu/virtual_dce: Remove the rmmod error messageâ??.
>
>Can you take a look at that patch or tell why or in which case the timer is not cancelled during IRQ put?
>
>â??
>Sincerely Yours,
>Pixel
>
>
>
>
>
>
>
>On 16/11/2017, 2:06 PM, "amd-gfx on behalf of Monk Liu" <amd-gfx-bounces at lists.freedesktop.org on behalf of Monk.Liu at amd.com> wrote:
>
>>virtual DCE Timer structure is already released
>>after its sw_fini(), so we need to cancel the
>>its Timer in hw_fini() otherwise the Timer canceling
>>is missed.
>>
>>v2:
>>use for loop and num_crtc to replace original code
>>
>>Change-Id: I03d6ca7aa07591d287da379ef4fe008f06edaff6
>>Signed-off-by: Monk Liu <Monk.Liu at amd.com>
>>Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
>>---
>> drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>>diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>>index cd4895b4..943efc3 100644
>>--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>>+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>>@@ -44,6 +44,9 @@ static void dce_virtual_set_display_funcs(struct amdgpu_device *adev);
>> static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev);
>> static int dce_virtual_connector_encoder_init(struct amdgpu_device *adev,
>> int index);
>>+static void dce_virtual_set_crtc_vblank_interrupt_state(struct amdgpu_device *adev,
>>+ int crtc,
>>+ enum amdgpu_interrupt_state state);
>>
>> /**
>> * dce_virtual_vblank_wait - vblank wait asic callback.
>>@@ -550,6 +553,13 @@ static int dce_virtual_hw_init(void *handle)
>>
>> static int dce_virtual_hw_fini(void *handle)
>> {
>>+ struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>>+ int i = 0;
>>+
>>+ for (i = 0; i<adev->mode_info.num_crtc; i++)
>>+ if (adev->mode_info.crtcs[i])
>>+ dce_virtual_set_crtc_vblank_interrupt_state(adev, i, AMDGPU_IRQ_STATE_DISABLE);
>>+
>> return 0;
>> }
>>
>>--
>>2.7.4
>>
>>_______________________________________________
>>amd-gfx mailing list
>>amd-gfx at lists.freedesktop.org
>>https://lists.freedesktop.org/mailman/listinfo/amd-gfx
