On 10/11/17 06:10 AM, S, Shirish wrote: > On 11/7/2017 2:06 PM, Michel Dänzer wrote: >> On 07/11/17 04:29 AM, S, Shirish wrote: >>> From: Shirish S <shirish.s at amd.com> >>> >>> This patch fixes static checker warning of >>> "warn: cast after binop" introduced by >>> 4d3e00dad80a: "drm/amd/display : add high part address calculation for underlay" >>> >>> Signed-off-by: Shirish S <shirish.s at amd.com> >>> --- >>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >>> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >>> index a87e5ac..e1bdf5e 100644 >>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c >>> @@ -1827,7 +1827,7 @@ static int fill_plane_attributes_from_fb(struct amdgpu_device *adev, >>> = lower_32_bits(fb_location); >>> plane_state->address.video_progressive.luma_addr.high_part >>> = upper_32_bits(fb_location); >>> - chroma_addr = fb_location + (u64)(awidth * fb->height); >>> + chroma_addr = fb_location + (u64)awidth * fb->height; >>> plane_state->address.video_progressive.chroma_addr.low_part >>> = lower_32_bits(chroma_addr); >>> plane_state->address.video_progressive.chroma_addr.high_part >>> @@ -2959,7 +2959,7 @@ static int dm_plane_helper_prepare_fb(struct drm_plane *plane, >>> = lower_32_bits(afb->address); >>> plane_state->address.video_progressive.luma_addr.high_part >>> = upper_32_bits(afb->address); >>> - chroma_addr = afb->address + (u64)(awidth * new_state->fb->height); >>> + chroma_addr = afb->address + (u64)awidth * new_state->fb->height; >>> plane_state->address.video_progressive.chroma_addr.low_part >>> = lower_32_bits(chroma_addr); >>> plane_state->address.video_progressive.chroma_addr.high_part >>> >> This code should really be removed, since fb_location is always 0 now >> in this function, so the values derived from it cannot be used for >> anything anyway. > I remember Andrey had some concerns with it, if he is ok with it i > can move it as a separate patch, for future bisect-ability. Harry already removed this code in amd-staging-drm-next commit f5887bb33b1e ("amdgpu/dm: Remove fb_location form fill_plane_attributes"). -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer