[PATCH v2 2/3] ASoC: rt5645: Wait for 400msec before concluding on value of RT5645_VENDOR_ID2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 11/8/2017 11:39 PM, Mark Brown wrote:
> On Wed, Nov 08, 2017 at 12:24:03PM -0500, Alex Deucher wrote:
> 
>>   	regmap_read(regmap, RT5645_VENDOR_ID2, &val);
>>   
>> +	/*
>> +	 * Read after 400msec, as it is the interval required between
>> +	 * read and power On.
>> +	 */
>> +	msleep(TIME_TO_POWER_MS);
>> +	regmap_read(regmap, RT5645_VENDOR_ID2, &val);
>> +
> 
> This leaves the original read in there so we've both got the early read
> (which might upset things potentially) and the delayed read.  Shouldn't
> we just be adding a msleep() before the existing read?
> 

My bad, I should have removed the addition of register read from the patch.


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux