[PATCH] drm/amd/display: checking for NULL instead of IS_ERR()

alexdeucher@xxxxxxxxx (Alex Deucher) · Mon, 6 Nov 2017 16:30:42 -0500

On Mon, Nov 6, 2017 at 6:51 AM, Christian KÃ¶nig
<christian.koenig at amd.com> wrote:
> Am 06.11.2017 um 12:43 schrieb Dan Carpenter:
>>
>> backlight_device_register() never returns NULL, it returns error
>> pointers on error so the check here is wrong.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>
>
> Acked-by: Christian KÃ¶nig <christian.koenig at amd.com>

Applied.  thanks!

Alex

>
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index 33a15a1d818c..75f9383f5b9b 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -1296,7 +1296,7 @@ amdgpu_dm_register_backlight_device(struct
>> amdgpu_display_manager *dm)
>>                         &amdgpu_dm_backlight_ops,
>>                         &props);
>>   -     if (NULL == dm->backlight_dev)
>> +       if (IS_ERR(dm->backlight_dev))
>>                 DRM_ERROR("DM: Backlight registration failed!\n");
>>         else
>>                 DRM_DEBUG_DRIVER("DM: Registered Backlight device: %s\n",
>> bl_name);
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx