On 23/05/17 10:28 AM, Deucher, Alexander wrote: >> -----Original Message----- >> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf >> Of Tom St Denis >> Sent: Monday, May 15, 2017 9:49 AM >> To: amd-gfx at lists.freedesktop.org >> Cc: StDenis, Tom >> Subject: [PATCH 5/5] drm/amd/amdgpu: Use modern 32/64-bit types in gfx6 >> >> Switch to uintNN_t from "uNN" types to be more consistent >> with modern coding styles. > > I think technically the uNN types are native for the kernel. the c99 > types are just for convenience. Seems like a lot of churn to me. > > Alex Fair enough but amdgpu is littered with files that use one or the other or sometimes both. :-) I agree it's low priority which is why I was attacking the lesser active SI code :-) Though I'm not offended if they're NAK'ed either way. Cheers, Tom