On Wed, May 17, 2017 at 04:16:31PM +0800, Koenig, Christian wrote: > Am 17.05.2017 um 09:55 schrieb Huang Rui: > > On Wed, May 17, 2017 at 03:43:47PM +0800, Zhou, David(ChunMing) wrote: > >> By this change, I suggest to remove mmhub/gfxhub_v1_0_ip_funcs and their > >> IP block, unify them to gmc ip block, this way we cannot lost setting > >> when resume back. > >> > > From hw side, wo won't have real gmc since this chip, mmhub and gfxhub(gc) > > instead of it. Maybe we would better to align with hw desgin. > > Yeah, I had patches for doing exactly this but then decided dropping it. > > What we should do is to have any one implementation of the code handling > both hubs and then have both as separate IP block in the list. > > Anyway for now both patches are Reviewed-by: Christian König > <christian.koenig at amd.com>. > > I assume that finally fixes S3 on Vega10? > No, but these fixes have improvement for the result. We can pass a round of gfx/cp/sdma test. But if we try to test a round again, it will encounter VM fault. Will tell you the detailed in another thread. Thanks, Rui
