FYI. In amdgpu-pro stack, it helps us that: - flexible to maintain the release process. (Add/remove/porting among different release branches) - libdrm git log will not be messed up with lots of updating commit - also helpful to support customers for such kind of issues. Regards, Jerry (Junwei Zhang) Linux Base Graphics SRDC Software Development _____________________________________ > -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf Of Li, > Samuel > Sent: Tuesday, May 16, 2017 4:43 > To: Michel Dänzer > Cc: amd-gfx at lists.freedesktop.org; Yuan, Xiaojie > Subject: RE: [PATCH 1/1] amdgpu: move asic id table to a separate file > > > Please provide specific reasons why this file cannot be in the libdrm repository > upstream. > A separate repo is preferred here, > 1) Keep a clean separation between code and data. > 2) Ideally, the commit of this data file should contain a Signed-Off-By: from > someone authoritative on the licensing of Marketing names, i.e. from someone > within the vendor (AMD). > It is very similar to linux-firmware repo in that it can be treated as a black box > from the vendor (It could be a binary if requested, as it is on Catalyst Windows > driver). > > I am open to other suggestions, if you would like to bring up. > > Regards, > Sam > > -----Original Message----- > From: Michel Dänzer [mailto:michel at daenzer.net] > Sent: Sunday, May 14, 2017 10:21 PM > To: Li, Samuel <Samuel.Li at amd.com> > Cc: amd-gfx at lists.freedesktop.org; Yuan, Xiaojie <Xiaojie.Yuan at amd.com> > Subject: Re: [PATCH 1/1] amdgpu: move asic id table to a separate file > > On 13/05/17 12:21 AM, Li, Samuel wrote: > > My understanding is this is actually a data file. Similar to amdgpu > > firmware, which is also separate from the kernel source code. > > I don't think the reasons for the linux-firmware repository being separate from > linux apply to this file. > > Please provide specific reasons why this file cannot be in the libdrm repository > upstream. > > > -- > Earthling Michel Dänzer | http://www.amd.com > Libre software enthusiast | Mesa and X developer > _______________________________________________ > amd-gfx mailing list > amd-gfx at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx