On Wed, Mar 19, 2025 at 8:53 AM Tomasz Pakuła
<tomasz.pakula.oficjalny@xxxxxxxxx> wrote:
>
> On Wed, 19 Mar 2025 at 03:19, Feng, Kenneth <Kenneth.Feng@xxxxxxx> wrote:
> >
> > [AMD Official Use Only - AMD Internal Distribution Only]
> >
> > -----Original Message-----
> > From: Tomasz Pakuła <tomasz.pakula.oficjalny@xxxxxxxxx>
> > Sent: Sunday, March 16, 2025 4:16 AM
> > To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Feng, Kenneth <Kenneth.Feng@xxxxxxx>; Wang, Yang(Kevin) <KevinYang.Wang@xxxxxxx>
> > Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> > Subject: [PATCH 2/2] drm/amd/pm: add zero RPM stop temp OD setting support for SMU 14.0.2
> >
> > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> >
> >
> > Hook up zero RPM stop temperature for 9070 and 9070 XT based on RDNA3 (smu 13.0.0 and 13.0.7) code.
> >
> > Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny@xxxxxxxxx>
> > ---
> > .../swsmu/inc/pmfw_if/smu14_driver_if_v14_0.h | 3 +- .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 50 ++++++++++++++++++-
> > 2 files changed, 51 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu14_driver_if_v14_0.h b/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu14_driver_if_v14_0.h
> > index c2fd0a4a13e5..a5eba7b91e2f 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu14_driver_if_v14_0.h
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu14_driver_if_v14_0.h
> > @@ -846,9 +846,10 @@ typedef struct {
> > uint16_t FanTargetTemperature; // Degree Celcius
> > //zero fan
> > uint8_t FanZeroRpmEnable;
> > + uint8_t FanZeroRpmStopTemp;
> > //temperature
> > uint8_t MaxOpTemp;
> > - uint8_t Padding1[2];
> > + uint8_t Padding1;
> > [Kenneth] - This change on this file is not required. The latest version on drm-next has the change.
> > Could you please confirm?
> > Thanks
>
> I just (19-03-2025 10:48 UTC) checked against the current drm-next and
> this is still needed.
> The last change to smu14_driver_if_v14_0.h was made 5 months ago by
> Kenneth Feng.
> It's the same state against which I made this patch.
What kernel are you using? I see the variable here:
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu14_driver_if_v14_0.h#n784
Alex
>
> Tomasz
