Re: [PATCH 1/2] drm/amdgpu: remove invalid usage of sched.ready

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 18, 2025 at 11:19 AM Christian König
<ckoenig.leichtzumerken@xxxxxxxxx> wrote:
>
> I can't count how often I had to remove this nonsense.
>
> Probably doesn't need an explanation any more.

Was actually about to send out the same patch.  Series is:
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

>
> Signed-off-by: Christian König <christian.koenig@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
> index 65fa583c34a4..9cb499195fff 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
> @@ -2675,7 +2675,6 @@ static int gfx_v12_0_cp_gfx_resume(struct amdgpu_device *adev)
>         u32 tmp;
>         u32 rb_bufsz;
>         u64 rb_addr, rptr_addr, wptr_gpu_addr;
> -       u32 i;
>
>         /* Set the write pointer delay */
>         WREG32_SOC15(GC, 0, regCP_RB_WPTR_DELAY, 0);
> @@ -2730,12 +2729,6 @@ static int gfx_v12_0_cp_gfx_resume(struct amdgpu_device *adev)
>
>         /* start the ring */
>         gfx_v12_0_cp_gfx_start(adev);
> -
> -       for (i = 0; i < adev->gfx.num_gfx_rings; i++) {
> -               ring = &adev->gfx.gfx_ring[i];
> -               ring->sched.ready = true;
> -       }
> -
>         return 0;
>  }
>
> @@ -3083,10 +3076,6 @@ static int gfx_v12_0_cp_async_gfx_ring_resume(struct amdgpu_device *adev)
>         if (r)
>                 goto done;
>
> -       for (i = 0; i < adev->gfx.num_gfx_rings; i++) {
> -               ring = &adev->gfx.gfx_ring[i];
> -               ring->sched.ready = true;
> -       }
>  done:
>         return r;
>  }
> --
> 2.34.1
>




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux