Re: [PATCH v2] drm/amdkfd: Fix instruction hazard in gfx12 trap handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 07/02/2025 23:38, Jay Cornwall wrote:
VALU instructions with SGPR source need wait states to avoid hazard
with SALU using different SGPR.

v2: Eliminate some hazards to reduce code explosion

Signed-off-by: Jay Cornwall <jay.cornwall@xxxxxxx>
Cc: Lancelot Six <lancelot.six@xxxxxxx>

Hi,

That looks good to me, thanks.  Sorry for the long delay to review.

Reviewed-by: Lancelot Six <lancelot.six@xxxxxxx>

Best,
Lancelot.

---
  .../gpu/drm/amd/amdkfd/cwsr_trap_handler.h    | 677 ++++++++++--------
  .../amd/amdkfd/cwsr_trap_handler_gfx12.asm    |  82 ++-
  2 files changed, 404 insertions(+), 355 deletions(-



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux