On Sun, Mar 9, 2025 at 12:47 PM Alex Deucher <alexdeucher@xxxxxxxxx> wrote: > > On Sat, Mar 8, 2025 at 3:39 AM Alexandre Demers > <alexandre.f.demers@xxxxxxxxx> wrote: > > > > Hi, > > > > While working on cleaning up sid.h, si_enums.h and some other SI > > related files, I've been scratching my head about why SI DMA files and > > variables were named "DMA" compared to CIK and over where "SDMA" is > > used. > > > > While I understand that a new system DMA was introduced with CIK, > > isn't SI DMA also a "system DMA"? Could we use the same naming > > convention and talk about sDMA, name defines values, shifts and masks? > > Could si_dma.c/.h be renamed to si_sdma.c/.h? Was the naming > > difference introduced to CIK so different that the naming covention > > needed to be modified? > > The SDMA IP was first added on CIK. SI used the older paging DMA IP > that first appeared on r6xx parts. While they are conceptually > similar (general purpose DMA copy/fill engines), the underlying > hardware and firmware was much different. I'm not sure what the > advantage would be to renaming it at this point other than code churn. > > Alex The only benefit would be to have closer define names, thus making comparisons between chip families easier. But the differences are not so important that they are actually preventing understanding what is going on. I'll keep things as they are then. Alexandre
