Hi Christian, On Wednesday 10 May 2017 13:30:37 Christian König wrote: > Am 10.05.2017 um 02:23 schrieb Michel Dänzer: > > On 03/05/17 09:46 PM, Christian König wrote: > >> Am 02.05.2017 um 22:04 schrieb SF Markus Elfring: > >>> From: Markus Elfring <elfring at users.sourceforge.net> > >>> Date: Tue, 2 May 2017 22:00:02 +0200 > >>> > >>> Three update suggestions were taken into account > >>> from static source code analysis. > >>> > >>> Markus Elfring (3): > >>> Use seq_putc() in radeon_sa_bo_dump_debug_info() > >>> Use seq_puts() in radeon_debugfs_pm_info() > >>> Use seq_puts() in r100_debugfs_cp_csq_fifo() > >> > >> Reviewed-by: Christian König <christian.koenig at amd.com> > > > > Based on > > https://lists.freedesktop.org/archives/dri-devel/2017-May/140837.html > > and followups, I'm afraid we'll have to make sure Markus' patches have > > been tested adequately before applying them. > > I can't judge the background of that decision, but at least those tree > patches for radeon looked trivial to me. > > I don't see much what could go wrong when merging them. For what it's worth, I've once applied a patch from Markus for the uvcvideo driver that seemed trivial but ended up introducing a breakage that I hadn't caught during review. I recommend rejecting Markus' patches that are not clear improvements, and carefully testing the others. > On the other hand you are right that trying to find hardware to test that > stuff could be challenging. -- Regards, Laurent Pinchart
