On Tue, Mar 4, 2025 at 4:29 AM Wentao Liang <vulab@xxxxxxxxxxx> wrote: > > Add error handling to propagate amdgpu_cgs_create_device() failures > to the caller. When amdgpu_cgs_create_device() fails, immediately > return -EINVAL to stop further processing and prevent null pointer > dereference. > > Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx> > --- > drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c > index 26624a716fc6..2cb05614466f 100644 > --- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c > +++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c > @@ -51,6 +51,8 @@ static int amd_powerplay_create(struct amdgpu_device *adev) > hwmgr->adev = adev; > hwmgr->not_vf = !amdgpu_sriov_vf(adev); > hwmgr->device = amdgpu_cgs_create_device(adev); > + if (!hwmgr->device) > + return -EINVAL; Please return -ENOMEM here. Also, you need to free hwmgr as well in this case. Alex > mutex_init(&hwmgr->msg_lock); > hwmgr->chip_family = adev->family; > hwmgr->chip_id = adev->asic_type; > -- > 2.42.0.windows.2 >
