Re: [PATCH v2 1/5] drm/amd: Copy entire structure in amdgpu_acpi_get_backlight_caps()

[Alex Hung <alex.hung@xxxxxxx>]

Reviewed-by: Alex Hung <alex.hung@xxxxxxx>

On 2/28/25 11:51, Mario Limonciello wrote:
> As new members are introduced to the structure copying the entire
> structure will help avoid missing them.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> index b8d4e07d2043..515c6f32448d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> @@ -1277,11 +1277,7 @@ void amdgpu_acpi_get_backlight_caps(struct amdgpu_dm_backlight_caps *caps)
>   {
>   	struct amdgpu_atif *atif = &amdgpu_acpi_priv.atif;
>   
> -	caps->caps_valid = atif->backlight_caps.caps_valid;
> -	caps->min_input_signal = atif->backlight_caps.min_input_signal;
> -	caps->max_input_signal = atif->backlight_caps.max_input_signal;
> -	caps->ac_level = atif->backlight_caps.ac_level;
> -	caps->dc_level = atif->backlight_caps.dc_level;
> +	memcpy(caps, &atif->backlight_caps, sizeof(*caps));
>   }
>   
>   /**