[Public]
Question: Why use the CONFIG_DRM_AMDGPU_NAVI3X_USERQ to guard all the various GFX user mode queue enablement paths? It seems more generic and reasonable to use the config name CONFIG_DRM_AMDGPU_NAVI3X_USERQ.
Except for that question, the series patch is Reviewed-by: Prike Liang <Prike.Liang@xxxxxxx> .
Regards,
Prike
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alex
> Deucher
> Sent: Saturday, March 1, 2025 3:54 AM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
> Subject: [PATCH 5/5] drm/amdgpu/userq: remove BROKEN from config
>
> This can be enabled now. We have the firmware checks in place.
>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
> b/drivers/gpu/drm/amd/amdgpu/Kconfig
> index a614320114796..23c014da0f324 100644
> --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
> +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
> @@ -98,7 +98,6 @@ config DRM_AMDGPU_WERROR config
> DRM_AMDGPU_NAVI3X_USERQ
> bool "Enable amdgpu usermode queues"
> depends on DRM_AMDGPU
> - depends on BROKEN
> default n
> help
> Choose this option to enable GFX usermode queue support for
> GFX/SDMA/Compute
> --
> 2.48.1
