[Public]
Reviewed-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@xxxxxxx>
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Joshi, Mukul
Sent: Monday, February 24, 2025 2:37 PM
To: Kim, Jonathan <Jonathan.Kim@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: RE: [PATCH] drm/amdkfd: enable cooperative launch on gfx12
[Public]
[Public]
Acked-by: Mukul Joshi <mukul.joshi@xxxxxxx>
> -----Original Message-----
> From: Kim, Jonathan <Jonathan.Kim@xxxxxxx>
> Sent: Friday, February 21, 2025 11:49 AM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Joshi, Mukul <Mukul.Joshi@xxxxxxx>; Kim, Jonathan
> <Jonathan.Kim@xxxxxxx>
> Subject: [PATCH] drm/amdkfd: enable cooperative launch on gfx12
>
> Even though GWS no longer exists, to maintain runtime usage for cooperative
> launch, SW set legacy GWS size.
>
> Signed-off-by: Jonathan Kim <jonathan.kim@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> index 9d20e169ec4a..095e73790dc4 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> @@ -590,9 +590,13 @@ static int kfd_gws_init(struct kfd_node *node)
> && kfd->mec2_fw_version >= 0x6b) ||
> (KFD_GC_VERSION(node) >= IP_VERSION(11, 0, 0)
> && KFD_GC_VERSION(node) < IP_VERSION(12, 0, 0)
> - && mes_rev >= 68))))
> + && mes_rev >= 68) ||
> + (KFD_GC_VERSION(node) >= IP_VERSION(12, 0, 0))))) {
> + if (KFD_GC_VERSION(node) >= IP_VERSION(12, 0, 0))
> + node->adev->gds.gws_size = 64;
> ret = amdgpu_amdkfd_alloc_gws(node->adev,
> node->adev->gds.gws_size, &node->gws);
> + }
>
> return ret;
> }
> --
> 2.34.1
