On Wed, Feb 12, 2025 at 10:22 AM Alex Deucher <alexander.deucher@xxxxxxx> wrote: > > VCN 2.5 doesn't support powergating so there is > no need to call these. > > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> Dropping this one. VCN 2.5 doesn't support powergating, but this function gets used for other stuff in the smu code. Alex > --- > drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c > index b9be304aa294b..08e73d1685e92 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c > +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c > @@ -1011,9 +1011,6 @@ static int vcn_v2_5_start(struct amdgpu_device *adev, int i) > if (adev->vcn.harvest_config & (1 << i)) > return 0; > > - if (adev->pm.dpm_enabled) > - amdgpu_dpm_enable_vcn(adev, true, i); > - > if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) > return vcn_v2_5_start_dpg_mode(adev, i, adev->vcn.indirect_sram); > > @@ -1465,9 +1462,6 @@ static int vcn_v2_5_stop(struct amdgpu_device *adev, int i) > UVD_POWER_STATUS__UVD_POWER_STATUS_MASK, > ~UVD_POWER_STATUS__UVD_POWER_STATUS_MASK); > > - if (adev->pm.dpm_enabled) > - amdgpu_dpm_enable_vcn(adev, false, i); > - > return 0; > } > > -- > 2.48.1 >