Re: [PATCH 4/4] drm/amdgpu/vcn4.0.3: drop dpm power helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2/12/2025 8:45 PM, Alex Deucher wrote:
> VCN 4.0.3 doesn't support powergating so there is
> no need to call these.
> 
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>

Patches 1, 2 & 4
	Reviewed-by: Lijo Lazar <lijo.lazar@xxxxxxx>

Patch 3
	Acked-by: Lijo Lazar <lijo.lazar@xxxxxxx>

Thanks,
Lijo

> ---
>  drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c
> index e09eaf4469ddf..acda694eb74ea 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c
> @@ -1127,11 +1127,6 @@ static int vcn_v4_0_3_start(struct amdgpu_device *adev)
>  	int i, j, k, r, vcn_inst;
>  	uint32_t tmp;
>  
> -	for (i = 0; i < adev->vcn.num_vcn_inst; ++i) {
> -		if (adev->pm.dpm_enabled)
> -			amdgpu_dpm_enable_vcn(adev, true, i);
> -	}
> -
>  	for (i = 0; i < adev->vcn.num_vcn_inst; ++i) {
>  		if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) {
>  			r = vcn_v4_0_3_start_dpg_mode(adev, i, adev->vcn.indirect_sram);
> @@ -1403,11 +1398,6 @@ static int vcn_v4_0_3_stop(struct amdgpu_device *adev)
>  		vcn_v4_0_3_enable_clock_gating(adev, i);
>  	}
>  Done:
> -	for (i = 0; i < adev->vcn.num_vcn_inst; ++i) {
> -		if (adev->pm.dpm_enabled)
> -			amdgpu_dpm_enable_vcn(adev, false, i);
> -	}
> -
>  	return 0;
>  }
>  




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux