On 2/11/2025 5:01 AM, Alex Deucher wrote:
> UVD and VCN were split into separate dpm helpers in commit
> ff69bba05f08 ("drm/amd/pm: add inst to dpm_set_powergating_by_smu")
> but the check at the top was still included UVD from an earlier
> version of the patch. Fix the check.
This description is not clear -'earlier version of the patch'. I see UVD
check is introduced by the same patch.
>
> Fixes: ff69bba05f08 ("drm/amd/pm: add inst to dpm_set_powergating_by_smu")
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3959
> Link: https://lists.freedesktop.org/archives/amd-gfx/2025-February/119827.html
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
Reviewed-by: Lijo Lazar <lijo.lazar@xxxxxxx>
Thanks,
Lijo
> Cc: Boyuan Zhang <boyuan.zhang@xxxxxxx>
> ---
> drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> index 6a9e26905edfc..7a22aef6e59c3 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> @@ -78,7 +78,7 @@ int amdgpu_dpm_set_powergating_by_smu(struct amdgpu_device *adev,
> int ret = 0;
> const struct amd_pm_funcs *pp_funcs = adev->powerplay.pp_funcs;
> enum ip_power_state pwr_state = gate ? POWER_STATE_OFF : POWER_STATE_ON;
> - bool is_vcn = (block_type == AMD_IP_BLOCK_TYPE_UVD || block_type == AMD_IP_BLOCK_TYPE_VCN);
> + bool is_vcn = block_type == AMD_IP_BLOCK_TYPE_VCN;
>
> if (atomic_read(&adev->pm.pwr_state[block_type]) == pwr_state &&
> (!is_vcn || adev->vcn.num_vcn_inst == 1)) {
