Hi Charlene, Alex, My scripts spotted that all 3 functions added by the commit dbc2309cac2a ("drm/amd/display: add hubbub_init related") are uncalled, and instead of deadcoding them, I wondered if it's actually a simple bug and they should be assigned somewhere. That patch also added a member dchubbub_init to struct hubbub_funcs so perhaps 2 of them should go there, and hmm there's dcn32_hubp_funcs for the other one??? Dave -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/