On 1/30/2025 12:14 PM, Mangesh Gadre wrote: > support gmc ip versioning though ip discovery binary > Suggest to rename subject as - Add support for umc 12.5.0/mmhub 1.8.1 Same for other patches in the series. The description may also need a change. Could be in the same lines of 'Add new IP version support' With those changes, series is - Reviewed-by: Lijo Lazar <lijo.lazar@xxxxxxx> Thanks, Lijo > Signed-off-by: Mangesh Gadre <Mangesh.Gadre@xxxxxxx> > Signed-off-by: Shiwu Zhang <shiwu.zhang@xxxxxxx> > Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > index 71b8ae7f2194..31c4eb656d98 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c > @@ -1498,6 +1498,7 @@ static void gmc_v9_0_set_umc_funcs(struct amdgpu_device *adev) > adev->umc.channel_idx_tbl = &umc_v6_7_channel_idx_tbl_second[0][0]; > break; > case IP_VERSION(12, 0, 0): > + case IP_VERSION(12, 5, 0): > adev->umc.max_ras_err_cnt_per_query = > UMC_V12_0_TOTAL_CHANNEL_NUM(adev) * UMC_V12_0_BAD_PAGE_NUM_PER_CHANNEL; > adev->umc.channel_inst_num = UMC_V12_0_CHANNEL_INSTANCE_NUM; > @@ -1523,6 +1524,7 @@ static void gmc_v9_0_set_mmhub_funcs(struct amdgpu_device *adev) > adev->mmhub.funcs = &mmhub_v1_7_funcs; > break; > case IP_VERSION(1, 8, 0): > + case IP_VERSION(1, 8, 1): > adev->mmhub.funcs = &mmhub_v1_8_funcs; > break; > default: