[PATCH xf86-video-amdgpu] Don't enable DRI3 without glamor

Alexander.Deucher@xxxxxxx (Deucher, Alexander) · Wed, 10 May 2017 16:10:55 +0000



> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Michel DÃ¤nzer
> Sent: Wednesday, May 10, 2017 5:49 AM
> To: amd-gfx at lists.freedesktop.org
> Subject: [PATCH xf86-video-amdgpu] Don't enable DRI3 without glamor
> 
> From: Michel DÃ¤nzer <michel.daenzer at amd.com>
> 
> Can't work currently. Fixes crash when trying to run a DRI3 client when
> glamor isn't enabled.
> 
> Bugzilla: https://bugs.freedesktop.org/100968
> Signed-off-by: Michel DÃ¤nzer <michel.daenzer at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  src/amdgpu_kms.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c
> index 0182cbe0a..4df81f993 100644
> --- a/src/amdgpu_kms.c
> +++ b/src/amdgpu_kms.c
> @@ -1741,7 +1741,10 @@ Bool
> AMDGPUScreenInit_KMS(SCREEN_INIT_ARGS_DECL)
>  #endif
> 
>  	if (!amdgpu_is_gpu_screen(pScreen)) {
> -		value = xorgGetVersion() >=
> XORG_VERSION_NUMERIC(1,18,3,0,0);
> +		if (xorgGetVersion() >=
> XORG_VERSION_NUMERIC(1,18,3,0,0))
> +			value = info->use_glamor;
> +		else
> +			value = FALSE;
>  		from = X_DEFAULT;
> 
>  		if (info->use_glamor) {
> --
> 2.11.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx