> +static void drm_atomic_colorop_print_state(struct drm_printer *p, > + const struct drm_colorop_state *state) > +{ > + struct drm_colorop *colorop = state->colorop; > + > + drm_printf(p, "colorop[%u]:\n", colorop->base.id); > + drm_printf(p, "\ttype=%s\n", drm_get_colorop_type_name(colorop->type)); > + drm_printf(p, "\tbypass=%u\n", state->bypass); > + drm_printf(p, "\tcurve_1d_type=%s\n", drm_get_colorop_curve_1d_type_name(state->curve_1d_type)); Could we only print this field if the type is 1D_CURVE?