On 1/11/2025 1:47 AM, Alex Deucher wrote: > From: Asad Kamal <asad.kamal@xxxxxxx> > > Fill ip version in pm_metrics for SMU v13.0.12 > > Signed-off-by: Asad Kamal <asad.kamal@xxxxxxx> > Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx> > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > index 8ab30b2f7119e..045a1a814c2a2 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c > @@ -603,6 +603,8 @@ static ssize_t smu_v13_0_6_get_pm_metrics(struct smu_context *smu, > pm_metrics->common_header.mp1_ip_discovery_version = IP_VERSION(13, 0, 6); > if (amdgpu_ip_version(smu->adev, MP1_HWIP, 0) == IP_VERSION(13, 0, 14)) > pm_metrics->common_header.mp1_ip_discovery_version = IP_VERSION(13, 0, 14); > + if (amdgpu_ip_version(smu->adev, MP1_HWIP, 0) == IP_VERSION(13, 0, 12)) > + pm_metrics->common_header.mp1_ip_discovery_version = IP_VERSION(13, 0, 12); Please remove all if checks and keep pm_metrics->common_header.mp1_ip_discovery_version = amdgpu_ip_version(smu->adev, MP1_HWIP, 0); Thanks, Lijo > pm_metrics->common_header.pmfw_version = pmfw_version; > pm_metrics->common_header.pmmetrics_version = table_version; > pm_metrics->common_header.structure_size =
