Re: [RFC PATCH] amd/ttm: test fence->ops->signaled before use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 07.01.25 um 21:01 schrieb James Zhu:
this original test condition is unclear.

No that is completely unnecessary.

The point is that with fence->ops->signaled provided the fence should make progress even without enabling signaling.

Why would you want to add this?

Regards,
Christian.


Signed-off-by: James Zhu <James.Zhu@xxxxxxx>
---
  drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 48c5365efca1..d40f07802c4f 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -218,7 +218,7 @@ static void ttm_bo_flush_all_fences(struct ttm_buffer_object *bo)
dma_resv_iter_begin(&cursor, resv, DMA_RESV_USAGE_BOOKKEEP);
  	dma_resv_for_each_fence_unlocked(&cursor, fence) {
-		if (!fence->ops->signaled)
+		if (fence->ops->signaled && !fence->ops->signaled(fence))
  			dma_fence_enable_sw_signaling(fence);
  	}
  	dma_resv_iter_end(&cursor);




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux