Re: [PATCH] drm/amdgpu: fill the ucode bo during psp resume for SRIOV

[Alex Deucher <alexdeucher@xxxxxxxxx>]

On Mon, Jan 6, 2025 at 6:12 AM Victor Zhao <Victor.Zhao@xxxxxxx> wrote:
>
> refill the ucode bo during psp resume for SRIOV, otherwise ucode load
> will fail after VM hibernation and fb clean.

Please drop the comment above amdgpu_ucode_init_bo() in psp_hw_init()
since it is no longer true.  WIth that fixed, the patch is:
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

>
> Signed-off-by: Victor Zhao <Victor.Zhao@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index 010c038b33ab..97fdd93c3ae3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -3148,6 +3148,10 @@ static int psp_resume(struct amdgpu_ip_block *ip_block)
>
>         mutex_lock(&adev->firmware.mutex);
>
> +       ret = amdgpu_ucode_init_bo(adev);
> +       if (ret)
> +               goto failed;
> +
>         ret = psp_hw_start(psp);
>         if (ret)
>                 goto failed;
> --
> 2.34.1
>