From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxx> Equally as with SDMA, the padding requirements for VPE are not great (16) so this is only done for consistency. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxx> Cc: Christian König <christian.koenig@xxxxxxx> Cc: Sunil Khatri <sunil.khatri@xxxxxxx> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c index 121ee17b522b..6c20ea754618 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c @@ -459,14 +459,13 @@ static int vpe_resume(struct amdgpu_ip_block *ip_block) static void vpe_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count) { - int i; + const u32 nop = ring->funcs->nop; - for (i = 0; i < count; i++) - if (i == 0) - amdgpu_ring_write(ring, ring->funcs->nop | - VPE_CMD_NOP_HEADER_COUNT(count - 1)); - else - amdgpu_ring_write(ring, ring->funcs->nop); + if (count == 0) + return; + + amdgpu_ring_write(ring, nop | VPE_CMD_NOP_HEADER_COUNT(--count)); + amdgpu_ring_fill(ring, nop, count); } static uint64_t vpe_get_csa_mc_addr(struct amdgpu_ring *ring, uint32_t vmid) -- 2.47.1